Review Request 109975: various fixes to sql scripts and package.json

[Giorgos Tsiapaliokas]

> On April 12, 2013, 5:19 p.m., Aleix Pol Gonzalez wrote:
> > sql/setup.sh, line 6
> > <http://git.reviewboard.kde.org/r/109975/diff/1/?file=138353#file138353line6>
> >
> >     Shouldn't these come from the config.json file?
> 
> Aaron J. Seigo wrote:
>     that would be nice, but it's not parsed/sourced by this script. it would mean either bringing in a json parser to this, or writing this in js. the latter wouldn't be the worst idea in the world, really.

>that would be nice,

I believe that we really need this.
The ideal is to do as many stuff as we can from the config.json(no?)

> but it's not parsed/sourced by this script. it would mean either bringing in a json parser to this, 

a json parser in bash.. well it will be ugly. No?

>or writing this in js. the latter wouldn't be the worst idea in the world, really.

I agree. writing stuff like this in js could make a quite good result.
After all in the end we need a language in which we will be able to write scripts.

options(this is my personal opinion):
a. use bash when its possible and some other language* when it isn't
b. use only the other language(overkill, see main.sh)

*other language
1. use perl/ruby/python/etc, this solution increases the complexity of the scripts. One more language with her idioms etc
2. use Qt, Qt hasn't been created for this reason
3. use js, seams logical. Its not perfect but since this is a node.js project
we must do with the nodeish way. A lot of people use js for their scripts.

I believe the a and 3 are the best solutions :)


- Giorgos


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109975/#review30962
-----------------------------------------------------------


On April 12, 2013, 2:40 p.m., Giorgos Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109975/
> -----------------------------------------------------------
> 
> (Updated April 12, 2013, 2:40 p.m.)
> 
> 
> Review request for Bodega.
> 
> 
> Description
> -------
> 
> This patch does,
> 
>     * adds a sql/updates dir
>     * impoves the setup.sh file
>     * executes the sql/updates scripts before npm updates
>     * populates the package.json
>     ** adds a restriction to node
>     ** overrides the default functionality of npm start
> 
> 
> Diffs
> -----
> 
>   README 7515b65 
>   server/package.json e68c27c 
>   sql/setup.sh 82cf22e 
>   sql/updates/README PRE-CREATION 
>   sql/updates/do_updates.sh PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/109975/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Giorgos Tsiapaliokas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/active/attachments/20130412/0404a41c/attachment-0001.html>