Review Request 109975: various fixes to sql scripts and package.json

[Aaron J. Seigo]

> On April 12, 2013, 5:19 p.m., Aleix Pol Gonzalez wrote:
> > sql/setup.sh, line 6
> > <http://git.reviewboard.kde.org/r/109975/diff/1/?file=138353#file138353line6>
> >
> >     Shouldn't these come from the config.json file?

that would be nice, but it's not parsed/sourced by this script. it would mean either bringing in a json parser to this, or writing this in js. the latter wouldn't be the worst idea in the world, really.


- Aaron J.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109975/#review30962
-----------------------------------------------------------


On April 12, 2013, 2:40 p.m., Giorgos Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109975/
> -----------------------------------------------------------
> 
> (Updated April 12, 2013, 2:40 p.m.)
> 
> 
> Review request for Bodega.
> 
> 
> Description
> -------
> 
> This patch does,
> 
>     * adds a sql/updates dir
>     * impoves the setup.sh file
>     * executes the sql/updates scripts before npm updates
>     * populates the package.json
>     ** adds a restriction to node
>     ** overrides the default functionality of npm start
> 
> 
> Diffs
> -----
> 
>   README 7515b65 
>   server/package.json e68c27c 
>   sql/setup.sh 82cf22e 
>   sql/updates/README PRE-CREATION 
>   sql/updates/do_updates.sh PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/109975/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Giorgos Tsiapaliokas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/active/attachments/20130412/262e9da1/attachment.html>