[rekonq] Review Request 109808: adds shortcuts for clone, pin and detach in the tabbar.

[Andrea Diamantini]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109808/#review30247
-----------------------------------------------------------


Mayank, it's 12 lines of code patch and there are 3 errors (explained) and 2 missing important things:
1) why do you need these shortcuts? why did you decide for those shortcuts? Other browsers have them? People is used to? Are them free shortcuts or are used somewhere else for some other things?
2) just adding to tabwidget the actions and adding the shortcuts will let it work just... the shortcuts! You HAVE to reimplement those action (eg: in the tabbar) using the NEW actions you added.

Last, I'm curious about your tests. How can it "runs well" if the called pinTab slot not even exist (at least not in the tabwidget)?

- Andrea Diamantini


On March 31, 2013, 7:20 p.m., mayank jha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109808/
> -----------------------------------------------------------
> 
> (Updated March 31, 2013, 7:20 p.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Description
> -------
> 
> Just additions to the action set in tabwidget.cpp!
> 
> 
> Diffs
> -----
> 
>   src/tabwindow/tabwidget.cpp a7b4f2b 
> 
> Diff: http://git.reviewboard.kde.org/r/109808/diff/
> 
> 
> Testing
> -------
> 
> tested and runs well! Just icons for pintab and clonetab, cant find it!
> 
> 
> Thanks,
> 
> mayank jha
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/rekonq/attachments/20130402/ee5e1d92/attachment.html>