<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109808/">http://git.reviewboard.kde.org/r/109808/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Mayank, it's 12 lines of code patch and there are 3 errors (explained) and 2 missing important things:
1) why do you need these shortcuts? why did you decide for those shortcuts? Other browsers have them? People is used to? Are them free shortcuts or are used somewhere else for some other things?
2) just adding to tabwidget the actions and adding the shortcuts will let it work just... the shortcuts! You HAVE to reimplement those action (eg: in the tabbar) using the NEW actions you added.
Last, I'm curious about your tests. How can it "runs well" if the called pinTab slot not even exist (at least not in the tabwidget)?</pre>
<br />
<p>- Andrea</p>
<br />
<p>On March 31st, 2013, 7:20 p.m. UTC, mayank jha wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for rekonq.</div>
<div>By mayank jha.</div>
<p style="color: grey;"><i>Updated March 31, 2013, 7:20 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Just additions to the action set in tabwidget.cpp!</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">tested and runs well! Just icons for pintab and clonetab, cant find it!</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/tabwindow/tabwidget.cpp <span style="color: grey">(a7b4f2b)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109808/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>