[rekonq] Review Request: Open Here feature for links’ context menu

[Andrea Diamantini]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105739/#review17397
-----------------------------------------------------------


I created a new patch about this feature request, trying to recreate konqueror behavior on hovering links. With it, rekonq simulates the same konqueror behavior and based on the guesses url type "change" its contextual menu, showing "open here" or "open in new tab" depending on the link target. Patch is in "IconLink" branch on remote rekonq repo.
Please, test and reply if it can fit your needs.

- Andrea Diamantini


On July 26, 2012, 6:17 p.m., Adrián Chaves Fernández wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105739/
> -----------------------------------------------------------
> 
> (Updated July 26, 2012, 6:17 p.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Description
> -------
> 
> Adds a context menu to open a link in the current page, as opposed to a new tab or window.
> 
> 
> This addresses bug https://bugs.kde.org/show_bug.cgi?id=303911.
>     /show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=303911
> 
> 
> Diffs
> -----
> 
>   src/webview.h 0141925 
>   src/webview.cpp 00112d6 
> 
> Diff: http://git.reviewboard.kde.org/r/105739/diff/
> 
> 
> Testing
> -------
> 
> I compiled it locally and it seems to work fine. I did not write unit tests because I am a newbie, and it would probably require me some time to find out how to do them. I will find the time if the feature is to be accepted.
> 
> 
> Thanks,
> 
> Adrián Chaves Fernández
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/rekonq/attachments/20120814/4d029314/attachment.html>