<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105739/">http://git.reviewboard.kde.org/r/105739/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I created a new patch about this feature request, trying to recreate konqueror behavior on hovering links. With it, rekonq simulates the same konqueror behavior and based on the guesses url type "change" its contextual menu, showing "open here" or "open in new tab" depending on the link target. Patch is in "IconLink" branch on remote rekonq repo.
Please, test and reply if it can fit your needs.</pre>
<br />
<p>- Andrea</p>
<br />
<p>On July 26th, 2012, 6:17 p.m., Adrián Chaves Fernández wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for rekonq.</div>
<div>By Adrián Chaves Fernández.</div>
<p style="color: grey;"><i>Updated July 26, 2012, 6:17 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Adds a context menu to open a link in the current page, as opposed to a new tab or window.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I compiled it locally and it seems to work fine. I did not write unit tests because I am a newbie, and it would probably require me some time to find out how to do them. I will find the time if the feature is to be accepted.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=303911">https://bugs.kde.org/show_bug.cgi?id=303911</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/webview.h <span style="color: grey">(0141925)</span></li>
<li>src/webview.cpp <span style="color: grey">(00112d6)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105739/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>