[rekonq] Re: Review Request: Fix bookmark toolbar context menu if there is a custom tool bar folder

[Yoann Laissus]

> On May 17, 2011, 9:47 p.m., Andrea Diamantini wrote:
> > Seems good :)
> > Commit it, please. Does this commit need to be backported (cherry-picked) in branches.0.7?

Ok, merged in master. I backported it but I added a part of this previous commit 339f1fe47ae8f6dcd799a674cdab65693a810d5f which also fix a similar issue. It adds new strings so I cannot backported it entirely.


- Yoann


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101369/#review3373
-----------------------------------------------------------


On May 15, 2011, 1:07 p.m., Yoann Laissus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101369/
> -----------------------------------------------------------
> 
> (Updated May 15, 2011, 1:07 p.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> Fix bookmark toolbar context menu if there is a custom tool bar folder :
> - The bookmark is now added in the correct folder
> - Forcing the null context menu for the root toolbar folder
> 
> Add the description field in the tooltip of bookmark panel's bookmarks
> 
> 
> Diffs
> -----
> 
>   src/bookmarks/bookmarkscontextmenu.h 416416e 
>   src/bookmarks/bookmarkscontextmenu.cpp 25cb9f2 
>   src/bookmarks/bookmarkstoolbar.cpp 57d56ff 
>   src/bookmarks/bookmarkstreemodel.cpp 8d82e2b 
> 
> Diff: http://git.reviewboard.kde.org/r/101369/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Yoann
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20110518/cb837dd4/attachment.htm