[rekonq] Re: Review Request: Fix bookmark toolbar context menu if there is a custom tool bar folder

Andrea Diamantini adjam7 at gmail.com
Tue May 17 23:47:07 CEST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101369/#review3373
-----------------------------------------------------------

Ship it!


Seems good :)
Commit it, please. Does this commit need to be backported (cherry-picked) in branches.0.7?

- Andrea


On May 15, 2011, 1:07 p.m., Yoann Laissus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101369/
> -----------------------------------------------------------
> 
> (Updated May 15, 2011, 1:07 p.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> Fix bookmark toolbar context menu if there is a custom tool bar folder :
> - The bookmark is now added in the correct folder
> - Forcing the null context menu for the root toolbar folder
> 
> Add the description field in the tooltip of bookmark panel's bookmarks
> 
> 
> Diffs
> -----
> 
>   src/bookmarks/bookmarkscontextmenu.h 416416e 
>   src/bookmarks/bookmarkscontextmenu.cpp 25cb9f2 
>   src/bookmarks/bookmarkstoolbar.cpp 57d56ff 
>   src/bookmarks/bookmarkstreemodel.cpp 8d82e2b 
> 
> Diff: http://git.reviewboard.kde.org/r/101369/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Yoann
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20110517/41fab9f0/attachment.htm 


More information about the rekonq mailing list