[rekonq] Re: Review Request: This is JuniorJob about doing better Tab Previews

[Andrea Diamantini]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101848/#review4617
-----------------------------------------------------------

Ship it!


Hi Vyacheslav,
and welcome aboard!
First of all, I'd like to say I'm sorry for the previous comment: it seems a bit "aggressive" reading it now and that was absolutely NOT my intention :)
Your patch looks and is very good! Please, just fix the things Johannes and Pierre pointed out and I'll be glad to merge it on rekonq master.
Keep up doing these beautiful things! And feel free to ask me if you need some more jumior jobs to play with ;)

- Andrea


On July 11, 2011, 10:13 a.m., Vyacheslav Blinov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101848/
> -----------------------------------------------------------
> 
> (Updated July 11, 2011, 10:13 a.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> Improvements:
> 
> * title of the page is removed since it is visible on a tab.
> * widget now has a smooth 3d look'n'feel with Oxygen thanks to raisen frame
> * widget has rouned corners in all the styles
> * url of the page is elided
> * with compositing tab previews will be shown semitransparent with 25% alpha by default, witch can be setted to be optional later
> * code of tab preview is now separated from tab bar so it is more explicit
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt db9506a 
>   src/tabbar.h c1b0ba5 
>   src/tabbar.cpp dee49ea 
>   src/tabpreviewpopup.h PRE-CREATION 
>   src/tabpreviewpopup.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/101848/diff
> 
> 
> Testing
> -------
> 
> Tested with different styles: it still looks ok, without compositing transparency didn't works
> 
> 
> Screenshots
> -----------
> 
> sample of tab preview
>   http://git.reviewboard.kde.org/r/101848/s/193/
> 
> 
> Thanks,
> 
> Vyacheslav
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20110711/da870e2d/attachment.htm