<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101848/">http://git.reviewboard.kde.org/r/101848/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hi Vyacheslav,
and welcome aboard!
First of all, I'd like to say I'm sorry for the previous comment: it seems a bit "aggressive" reading it now and that was absolutely NOT my intention :)
Your patch looks and is very good! Please, just fix the things Johannes and Pierre pointed out and I'll be glad to merge it on rekonq master.
Keep up doing these beautiful things! And feel free to ask me if you need some more jumior jobs to play with ;)</pre>
<br />
<p>- Andrea</p>
<br />
<p>On July 11th, 2011, 10:13 a.m., Vyacheslav Blinov wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for rekonq.</div>
<div>By Vyacheslav Blinov.</div>
<p style="color: grey;"><i>Updated July 11, 2011, 10:13 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Improvements:
* title of the page is removed since it is visible on a tab.
* widget now has a smooth 3d look'n'feel with Oxygen thanks to raisen frame
* widget has rouned corners in all the styles
* url of the page is elided
* with compositing tab previews will be shown semitransparent with 25% alpha by default, witch can be setted to be optional later
* code of tab preview is now separated from tab bar so it is more explicit</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested with different styles: it still looks ok, without compositing transparency didn't works</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/CMakeLists.txt <span style="color: grey">(db9506a)</span></li>
<li>src/tabbar.h <span style="color: grey">(c1b0ba5)</span></li>
<li>src/tabbar.cpp <span style="color: grey">(dee49ea)</span></li>
<li>src/tabpreviewpopup.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/tabpreviewpopup.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101848/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/101848/s/193/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2011/07/04/screenshot_400x100.png" style="border: 1px black solid;" alt="sample of tab preview" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>