[rekonq] Re: Review Request: New "new tab page" is here !

[Andrea Diamantini]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100456/#review1253
-----------------------------------------------------------


CMakeFiles/kdeinit_rekonq.dir/webpage.cpp.o: In function `.L860':                                                                         
/SW/BRANCH/BUILD/rekonq/src/webpage.moc:97: undefined reference to `WebPage::copyToTempFileResult(KJob*)'
collect2: ld returned 1 exit status
make[2]: *** [lib/libkdeinit4_rekonq.so] Error 1
make[1]: *** [src/CMakeFiles/kdeinit_rekonq.dir/all] Error 2
make: *** [all] Error 2

:(

- Andrea


On Feb. 3, 2011, 2:54 p.m., Pierre Rossi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100456/
> -----------------------------------------------------------
> 
> (Updated Feb. 3, 2011, 2:54 p.m.)
> 
> 
> Review request for rekonq, Andrea Diamantini, Lionel Chauvin, and Benjamin Poulain.
> 
> 
> Summary
> -------
> 
> As expected, the diff is pretty huge, and since the rebase started to look messy, I actually dropped some of the earlier changes from before we decided to go hybrid and made a new branch, so here it is:
> 
> http://gitorious.org/~elproxy/rekonq/elproxys-rekonq/commits/hybridRebased
> 
> 
> Diffs
> -----
> 
>   src/application.h b30e337 
>   src/CMakeLists.txt 6cf2651 
>   src/application.cpp f38832c 
>   src/data/CMakeLists.txt f34936b 
>   src/data/bg.png 5ec669a 
>   src/data/bg2.png 1ded269 
>   src/data/bookmarks.js PRE-CREATION 
>   src/data/closedtabs.js PRE-CREATION 
>   src/data/downloads.js PRE-CREATION 
>   src/data/favorites.js PRE-CREATION 
>   src/data/history.js PRE-CREATION 
>   src/data/home.html df8f409 
>   src/data/images/arrow-down.png PRE-CREATION 
>   src/data/images/arrow-right.png PRE-CREATION 
>   src/data/images/navigation_background.png PRE-CREATION 
>   src/data/images/tile_background.png PRE-CREATION 
>   src/data/index.html PRE-CREATION 
>   src/data/rekonq_newtab.css PRE-CREATION 
>   src/data/tile.gif 32e06ff 
>   src/data/tools.js PRE-CREATION 
>   src/data/ui.css PRE-CREATION 
>   src/data/ui.js PRE-CREATION 
>   src/downloadmanager.h PRE-CREATION 
>   src/downloadmanager.cpp PRE-CREATION 
>   src/filterurljob.cpp 53b52b7 
>   src/history/historymanager.h 60598ce 
>   src/history/historymanager.cpp 59cc121 
>   src/main.cpp dcf996e 
>   src/mainview.h bc8b676 
>   src/mainview.cpp 699103a 
>   src/mainwindow.cpp ece11cc 
>   src/networkaccessmanager.cpp 9d9101b 
>   src/newtabpage.h be02d9d 
>   src/newtabpage.cpp 7dcc958 
>   src/newtabpage/bookmarkiterator.h PRE-CREATION 
>   src/newtabpage/bookmarkiterator.cpp PRE-CREATION 
>   src/newtabpage/bookmarktab.h PRE-CREATION 
>   src/newtabpage/bookmarktab.cpp PRE-CREATION 
>   src/newtabpage/bridgeutils.h PRE-CREATION 
>   src/newtabpage/bridgeutils.cpp PRE-CREATION 
>   src/newtabpage/closedtabs.h PRE-CREATION 
>   src/newtabpage/closedtabs.cpp PRE-CREATION 
>   src/newtabpage/downloaditem.h PRE-CREATION 
>   src/newtabpage/downloaditem.cpp PRE-CREATION 
>   src/newtabpage/downloadtab.h PRE-CREATION 
>   src/newtabpage/downloadtab.cpp PRE-CREATION 
>   src/newtabpage/favoriteitem.h PRE-CREATION 
>   src/newtabpage/favoriteitem.cpp PRE-CREATION 
>   src/newtabpage/favoritestab.h PRE-CREATION 
>   src/newtabpage/favoritestab.cpp PRE-CREATION 
>   src/newtabpage/historyitemiterator.h PRE-CREATION 
>   src/newtabpage/historyitemiterator.cpp PRE-CREATION 
>   src/newtabpage/historytab.h PRE-CREATION 
>   src/newtabpage/historytab.cpp PRE-CREATION 
>   src/newtabpage/javascriptguard.h PRE-CREATION 
>   src/newtabpage/rekonqreply.h PRE-CREATION 
>   src/newtabpage/rekonqreply.cpp PRE-CREATION 
>   src/newtabpage/tabobject.h PRE-CREATION 
>   src/newtabpage/tabobject.cpp PRE-CREATION 
>   src/previewselectorbar.h 9684a01 
>   src/previewselectorbar.cpp c8ab5b0 
>   src/protocolhandler.cpp 6dfc33a 
>   src/tabbar.cpp 7a8419a 
>   src/webpage.h 7633b26 
>   src/webpage.cpp c074f1a 
>   src/websnap.h e5b550f 
>   src/websnap.cpp 54cf105 
>   src/webtab.h 7b7c3c7 
>   src/webtab.cpp 1305747 
>   src/webview.cpp d3eb2f4 
> 
> Diff: http://git.reviewboard.kde.org/r/100456/diff
> 
> 
> Testing
> -------
> 
> "Tested and works™" :)
> 
> Well, there are still a few known issues with fixes to be expected in the next two weeks (for instance the about: to rekonq:// conversion, necessary for WebKit to even request loading the page, isn't perfect and transparent to the user yet). 
> And the design of the pages (trying to mimic the original as much as possible for now) is not yet totally polished, and that's definitely not set in stone for the future.
>  
> 
> 
> Screenshots
> -----------
> 
> Favorites
>   http://git.reviewboard.kde.org/r/100456/s/60/
> Downloads
>   http://git.reviewboard.kde.org/r/100456/s/61/
> 
> 
> Thanks,
> 
> Pierre
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20110206/025f507f/attachment-0001.htm