<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100456/">http://git.reviewboard.kde.org/r/100456/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">CMakeFiles/kdeinit_rekonq.dir/webpage.cpp.o: In function `.L860':
/SW/BRANCH/BUILD/rekonq/src/webpage.moc:97: undefined reference to `WebPage::copyToTempFileResult(KJob*)'
collect2: ld returned 1 exit status
make[2]: *** [lib/libkdeinit4_rekonq.so] Error 1
make[1]: *** [src/CMakeFiles/kdeinit_rekonq.dir/all] Error 2
make: *** [all] Error 2
:(</pre>
<br />
<p>- Andrea</p>
<br />
<p>On February 3rd, 2011, 2:54 p.m., Pierre Rossi wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for rekonq, Andrea Diamantini, Lionel Chauvin, and Benjamin Poulain.</div>
<div>By Pierre Rossi.</div>
<p style="color: grey;"><i>Updated Feb. 3, 2011, 2:54 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">As expected, the diff is pretty huge, and since the rebase started to look messy, I actually dropped some of the earlier changes from before we decided to go hybrid and made a new branch, so here it is:
http://gitorious.org/~elproxy/rekonq/elproxys-rekonq/commits/hybridRebased</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">"Tested and works™" :)
Well, there are still a few known issues with fixes to be expected in the next two weeks (for instance the about: to rekonq:// conversion, necessary for WebKit to even request loading the page, isn't perfect and transparent to the user yet).
And the design of the pages (trying to mimic the original as much as possible for now) is not yet totally polished, and that's definitely not set in stone for the future.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/application.h <span style="color: grey">(b30e337)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(6cf2651)</span></li>
<li>src/application.cpp <span style="color: grey">(f38832c)</span></li>
<li>src/data/CMakeLists.txt <span style="color: grey">(f34936b)</span></li>
<li>src/data/bg.png <span style="color: grey">(5ec669a)</span></li>
<li>src/data/bg2.png <span style="color: grey">(1ded269)</span></li>
<li>src/data/bookmarks.js <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/data/closedtabs.js <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/data/downloads.js <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/data/favorites.js <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/data/history.js <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/data/home.html <span style="color: grey">(df8f409)</span></li>
<li>src/data/images/arrow-down.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/data/images/arrow-right.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/data/images/navigation_background.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/data/images/tile_background.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/data/index.html <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/data/rekonq_newtab.css <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/data/tile.gif <span style="color: grey">(32e06ff)</span></li>
<li>src/data/tools.js <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/data/ui.css <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/data/ui.js <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/downloadmanager.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/downloadmanager.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/filterurljob.cpp <span style="color: grey">(53b52b7)</span></li>
<li>src/history/historymanager.h <span style="color: grey">(60598ce)</span></li>
<li>src/history/historymanager.cpp <span style="color: grey">(59cc121)</span></li>
<li>src/main.cpp <span style="color: grey">(dcf996e)</span></li>
<li>src/mainview.h <span style="color: grey">(bc8b676)</span></li>
<li>src/mainview.cpp <span style="color: grey">(699103a)</span></li>
<li>src/mainwindow.cpp <span style="color: grey">(ece11cc)</span></li>
<li>src/networkaccessmanager.cpp <span style="color: grey">(9d9101b)</span></li>
<li>src/newtabpage.h <span style="color: grey">(be02d9d)</span></li>
<li>src/newtabpage.cpp <span style="color: grey">(7dcc958)</span></li>
<li>src/newtabpage/bookmarkiterator.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/newtabpage/bookmarkiterator.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/newtabpage/bookmarktab.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/newtabpage/bookmarktab.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/newtabpage/bridgeutils.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/newtabpage/bridgeutils.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/newtabpage/closedtabs.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/newtabpage/closedtabs.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/newtabpage/downloaditem.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/newtabpage/downloaditem.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/newtabpage/downloadtab.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/newtabpage/downloadtab.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/newtabpage/favoriteitem.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/newtabpage/favoriteitem.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/newtabpage/favoritestab.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/newtabpage/favoritestab.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/newtabpage/historyitemiterator.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/newtabpage/historyitemiterator.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/newtabpage/historytab.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/newtabpage/historytab.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/newtabpage/javascriptguard.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/newtabpage/rekonqreply.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/newtabpage/rekonqreply.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/newtabpage/tabobject.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/newtabpage/tabobject.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/previewselectorbar.h <span style="color: grey">(9684a01)</span></li>
<li>src/previewselectorbar.cpp <span style="color: grey">(c8ab5b0)</span></li>
<li>src/protocolhandler.cpp <span style="color: grey">(6dfc33a)</span></li>
<li>src/tabbar.cpp <span style="color: grey">(7a8419a)</span></li>
<li>src/webpage.h <span style="color: grey">(7633b26)</span></li>
<li>src/webpage.cpp <span style="color: grey">(c074f1a)</span></li>
<li>src/websnap.h <span style="color: grey">(e5b550f)</span></li>
<li>src/websnap.cpp <span style="color: grey">(54cf105)</span></li>
<li>src/webtab.h <span style="color: grey">(7b7c3c7)</span></li>
<li>src/webtab.cpp <span style="color: grey">(1305747)</span></li>
<li>src/webview.cpp <span style="color: grey">(d3eb2f4)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100456/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/100456/s/60/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2011/01/28/rekonq-favorites_400x100.jpeg" style="border: 1px black solid;" alt="Favorites" /></a>
<a href="http://git.reviewboard.kde.org/r/100456/s/61/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2011/01/28/rekonq-downloads_400x100.jpeg" style="border: 1px black solid;" alt="Downloads" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>