D19192: [Updates page] Improve selected/unselected explanation view

Aleix Pol Gonzalez noreply at phabricator.kde.org
Thu Feb 21 20:03:02 GMT 2019


apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  Otherwise it should go in.

INLINE COMMENTS

> UpdatesPage.qml:110
>                  Layout.fillWidth: true
> +                text: (page.unselected === 0 ? i18n("All updates selected") : i18np("%1/%2 update selected", "%1/%2 updates selected", updateModel.toUpdateCount, updateModel.totalUpdatesCount)) + " (" + updateModel.updateSize + ")"
> +                elide: Text.ElideRight

instead of appending the `(123)` bit in the end, can you include it in the i18np call?

REPOSITORY
  R134 Discover Software Store

BRANCH
  improve-selected-updated-view (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19192

To: ngraham, #vdg, #discover_software_store, apol
Cc: apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190221/a1fbc5be/attachment.html>


More information about the Plasma-devel mailing list