<table><tr><td style="">apol accepted this revision.<br />apol added a comment.<br />This revision is now accepted and ready to land.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D19192">View Revision</a></tr></table><br /><div><div><p>Otherwise it should go in.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D19192#inline-107163">View Inline</a><span style="color: #4b4d51; font-weight: bold;">UpdatesPage.qml:110</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">                <span style="color: #aa4000">Layout.fillWidth:</span> <span style="color: #000a65">true</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                <span style="color: #aa4000">text:</span> <span class="p">(</span><span style="color: #004012">page</span><span class="p">.</span><span style="color: #004012">unselected</span> <span style="color: #aa2211">===</span> <span style="color: #601200">0</span> <span style="color: #aa2211">?</span> <span style="color: #004012">i18n</span><span class="p">(</span><span style="color: #766510">"All updates selected"</span><span class="p">)</span> <span style="color: #aa2211">:</span> <span style="color: #004012">i18np</span><span class="p">(</span><span style="color: #766510">"%1/%2 update selected"</span><span class="p">,</span> <span style="color: #766510">"%1/%2 updates selected"</span><span class="p">,</span> <span style="color: #004012">updateModel</span><span class="p">.</span><span style="color: #004012">toUpdateCount</span><span class="p">,</span> <span style="color: #004012">updateModel</span><span class="p">.</span><span style="color: #004012">totalUpdatesCount</span><span class="p">))</span> <span style="color: #aa2211">+</span> <span style="color: #766510">" ("</span> <span style="color: #aa2211">+</span> <span style="color: #004012">updateModel</span><span class="p">.</span><span style="color: #004012">updateSize</span> <span style="color: #aa2211">+</span> <span style="color: #766510">")"</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                <span style="color: #aa4000">elide:</span> <span style="color: #004012">Text</span><span class="p">.</span><span style="color: #004012">ElideRight</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">instead of appending the <tt style="background: #ebebeb; font-size: 13px;">(123)</tt> bit in the end, can you include it in the i18np call?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R134 Discover Software Store</div></div></div><br /><div><strong>BRANCH</strong><div><div>improve-selected-updated-view (branched from master)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D19192">https://phabricator.kde.org/D19192</a></div></div><br /><div><strong>To: </strong>ngraham, VDG, Discover Software Store, apol<br /><strong>Cc: </strong>apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart<br /></div>