D18918: Make the text of "View Settings" action more specific

[Michail Vourlakos]

mvourlakos added a comment.


  Personally I dont like the approach, this wont work in some cases e.g. when right clicking plasma taskmanager.
  This actions are located at : https://phabricator.kde.org/source/latte-dock/browse/master/containmentactions/contextmenu/menu.cpp
  
  I would try first in there to check if it is possible to track a parent e.g. of Latte::View

INLINE COMMENTS

> trmdi wrote in view.cpp:333
> I've found a bug here: when inEditMode, `m_behaveAsPlasmaPanel` is always "false".
> Could you explain why?

behaveAsPlasmaPanel as a variable defines only the behavior of the view and not the type. Currently the Latte::View does not have a type in order to be used by other elements. How this could be done is the following:

1. add in Latte::View a type variable which is going to be available through qml to be altered
2. containment qml is going to be responsible for [1] to be set propertly
3. [1] wont be altered in edit mode like behaveAsPlasmaPanel is

I can do [1-3] if you want in order to build after.

In edit mode the behaveIsPlasmaPanel is false because it editMode the view must not function as a plasma panel in order to support the animations correctly, set its sizes properly, set its masks correctly etc.

REPOSITORY
  R878 Latte Dock

REVISION DETAIL
  https://phabricator.kde.org/D18918

To: trmdi, mvourlakos
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190211/63f6916c/attachment.html>