D18918: Make the text of "View Settings" action more specific

Tranter Madi noreply at phabricator.kde.org
Mon Feb 11 08:12:02 GMT 2019


trmdi added inline comments.

INLINE COMMENTS

> view.cpp:333
> +    };
> +    const QString viewSettingsText(m_behaveAsPlasmaPanel? viewSettingsTexts[1] : viewSettingsTexts[2]);
> +    const QString strippedText(a->text().replace("&", ""));

I've found a bug here: when inEditMode, `m_behaveAsPlasmaPanel` is always "false".
Could you explain why?

REPOSITORY
  R878 Latte Dock

REVISION DETAIL
  https://phabricator.kde.org/D18918

To: trmdi, mvourlakos
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190211/54402d65/attachment-0001.html>


More information about the Plasma-devel mailing list