D18896: [plasma-nm] Refresh wifi networks as fast as possible

Jan Grulich noreply at phabricator.kde.org
Mon Feb 11 07:05:50 GMT 2019


jgrulich added inline comments.

INLINE COMMENTS

> handler.cpp:64
>  
> +namespace {
> +    const int wirelessScanRetryInterval = 2000; // Interval (in ms) between attempts to scan for wifi networks

It doesn't need to be in namespace.

> handler.cpp:444
> +    qCDebug(PLASMA_NM) << "Trying soon a new scan on" << interface;
> +    m_WirelessScanRetryTimer.callOnTimeout([this,interface]() {
> +        m_WirelessScanRetryTimer.disconnect();

This is Qt 5.12 only, Plasma 5.16 is going to depend on it so if you plan to you this, you should bump required Qt version.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D18896

To: vpilo, jgrulich, ngraham, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190211/04c2f530/attachment.html>


More information about the Plasma-devel mailing list