D18689: plasma-nm Connection Icon not showing correct icon when using a bridge

[Ronnie Thomas]

rthomas added a comment.


  In D18689#404506 <https://phabricator.kde.org/D18689#404506>, @jgrulich wrote:
  
  > Correct fix would be to set icon for bridge connections in the last else branch at the end of setIcons() method, probably guarded with a condition whether the user has enabled virtual connections.
  
  
  I'm not sure plasma-nm has ever used icons for bridges. Even at the end of setIcons() we are just ignoring every other device (https://cgit.kde.org/plasma-nm.git/tree/libs/declarative/connectionicon.cpp#n440) and calling setDisconnectedIcon(). This bug doesn't have to be limited to a bridge, even if I add a Dummy interface via NetworkManager, NetworkManager will consider that the ActivatingConnection and plasma-nm will not select the proper icon because of that.
  
  I think virtual devices should be considered secondary and not be considered when choosing an icon.
  
  PS: PrimaryConnection for me is always the Wifi connection for some reason, and the Bridge is always chosen as the ActivatingConnection

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D18689

To: rthomas, jgrulich, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190203/e3d76b19/attachment.html>