Review Request 128475: [KDE GTK Settings] Add "left mouse button wraps scroll bar" setting

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128475/#review97542
-----------------------------------------------------------


Ship it!




It's unfortunate that this needs to be in the KCM rather than the GTK style, but LGTM.

- Aleix Pol Gonzalez


On July 18, 2016, 4:30 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128475/
> -----------------------------------------------------------
> 
> (Updated July 18, 2016, 4:30 p.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: kde-gtk-config
> 
> 
> Description
> -------
> 
> GTK 3 by default warps the scroll bar when left clicking it outside the draggable part.
> 
> This makes it inconsistent with Qt apps (and virtually any other toolkit) that does that on middle click with left click only scrolling up or down a page.
> 
> 
> Diffs
> -----
> 
>   src/abstractappearance.h ddf063c 
>   src/abstractappearance.cpp 6b46105 
>   src/appearancegtk2.cpp 7a5c8a5 
>   src/appearancegtk3.cpp 90fc4d8 
>   src/appearencegtk.h 5a6e6c1 
>   src/appearencegtk.cpp acb2c0a 
>   src/gtkconfigkcmodule.cpp 3477dbd 
>   src/ui/gui.ui 66a8966 
>   tests/configsavetest.cpp cc3d423 
> 
> Diff: https://git.reviewboard.kde.org/r/128475/diff/
> 
> 
> Testing
> -------
> 
> Tests pass.
> 
> Checked checkbox, setting was written, Firefox scrolled like mental.
> Unchecked checkbox, setting was written, Firefox scrolled like anybody else.
> 
> Is there a startup script or kded module that writes these settings initially, like Breeze icons? I think the false should be there by default to make it consistent with all other applications.
> 
> 
> File Attachments
> ----------------
> 
> Setting
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/07/18/75d42a10-4557-4b2d-8539-f0aeb8c30a05__Screenshot_20160718_155720.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160718/c077580e/attachment.html>