<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128475/">https://git.reviewboard.kde.org/r/128475/</a>
</td>
</tr>
</table>
<br />
<p>
Ship it!
</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It's unfortunate that this needs to be in the KCM rather than the GTK style, but LGTM.</p></pre>
<br />
<p>- Aleix Pol Gonzalez</p>
<br />
<p>On July 18th, 2016, 4:30 p.m. CEST, Kai Uwe Broulik wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma and KDE Usability.</div>
<div>By Kai Uwe Broulik.</div>
<p style="color: grey;"><i>Updated July 18, 2016, 4:30 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-gtk-config
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">GTK 3 by default warps the scroll bar when left clicking it outside the draggable part.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This makes it inconsistent with Qt apps (and virtually any other toolkit) that does that on middle click with left click only scrolling up or down a page.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Tests pass.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Checked checkbox, setting was written, Firefox scrolled like mental.
Unchecked checkbox, setting was written, Firefox scrolled like anybody else.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Is there a startup script or kded module that writes these settings initially, like Breeze icons? I think the false should be there by default to make it consistent with all other applications.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/abstractappearance.h <span style="color: grey">(ddf063c)</span></li>
<li>src/abstractappearance.cpp <span style="color: grey">(6b46105)</span></li>
<li>src/appearancegtk2.cpp <span style="color: grey">(7a5c8a5)</span></li>
<li>src/appearancegtk3.cpp <span style="color: grey">(90fc4d8)</span></li>
<li>src/appearencegtk.h <span style="color: grey">(5a6e6c1)</span></li>
<li>src/appearencegtk.cpp <span style="color: grey">(acb2c0a)</span></li>
<li>src/gtkconfigkcmodule.cpp <span style="color: grey">(3477dbd)</span></li>
<li>src/ui/gui.ui <span style="color: grey">(66a8966)</span></li>
<li>tests/configsavetest.cpp <span style="color: grey">(cc3d423)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128475/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/07/18/75d42a10-4557-4b2d-8539-f0aeb8c30a05__Screenshot_20160718_155720.png">Setting</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>