Review Request 116460: Footer clock fix

[Sebastian Kügler]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116460/#review51326
-----------------------------------------------------------


This fix is wrong, it's merely trying to handle a symptom. The root cause of this erratic behavior is that we're making up our own time formatting code. The right approach would entail:

- Getting the right timezone (The time dataengine knows it)
- Using a correct timeformatting function, such as Qt.formatDateTime or one in the org.kde.klocale import (as Bhushan notes)

If you need inspiration for a fix, have a look at the digital clock in Plasma Next (kde-workspace/plasma/generic/applets/digital-clock). Also, please pay attention to correct indentation. If the code doesn't look tidy, it can't go in.

There is already a review request for this, you've probably seen it as you've CC:ed the author of that patch. You should, however, also have read the comments, as this "solution" is the exact same as in that patch. I'm not sure what's going on here, but you should try not to step on each others toes.

- Sebastian Kügler


On Feb. 27, 2014, 9:12 p.m., Maulik Kotadia wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116460/
> -----------------------------------------------------------
> 
> (Updated Feb. 27, 2014, 9:12 p.m.)
> 
> 
> Review request for Plasma, R.Harish  Navnit, Shantanu Tushar, and Sinny Kumari.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> -------
> 
> The footer clock in PMC is set to 12Hr format and it was showing 0:00 AM instead of 12:00 AM 
> 
> 
> Diffs
> -----
> 
>   mediaelements/mediawelcome/HomeScreenFooter.qml d2c0eb7 
> 
> Diff: https://git.reviewboard.kde.org/r/116460/diff/
> 
> 
> Testing
> -------
> 
> I've tested the diff and its working correctly
> 
> 
> Thanks,
> 
> Maulik Kotadia
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140228/e0dead88/attachment.html>