<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/116460/">https://git.reviewboard.kde.org/r/116460/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This fix is wrong, it's merely trying to handle a symptom. The root cause of this erratic behavior is that we're making up our own time formatting code. The right approach would entail:
- Getting the right timezone (The time dataengine knows it)
- Using a correct timeformatting function, such as Qt.formatDateTime or one in the org.kde.klocale import (as Bhushan notes)
If you need inspiration for a fix, have a look at the digital clock in Plasma Next (kde-workspace/plasma/generic/applets/digital-clock). Also, please pay attention to correct indentation. If the code doesn't look tidy, it can't go in.
There is already a review request for this, you've probably seen it as you've CC:ed the author of that patch. You should, however, also have read the comments, as this "solution" is the exact same as in that patch. I'm not sure what's going on here, but you should try not to step on each others toes.</pre>
<br />
<p>- Sebastian Kügler</p>
<br />
<p>On February 27th, 2014, 9:12 p.m. UTC, Maulik Kotadia wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma, R.Harish Navnit, Shantanu Tushar, and Sinny Kumari.</div>
<div>By Maulik Kotadia.</div>
<p style="color: grey;"><i>Updated Feb. 27, 2014, 9:12 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-mediacenter
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The footer clock in PMC is set to 12Hr format and it was showing 0:00 AM instead of 12:00 AM </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I've tested the diff and its working correctly</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>mediaelements/mediawelcome/HomeScreenFooter.qml <span style="color: grey">(d2c0eb7)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/116460/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>