Review Request: Plasmate:now StartPage::createNewProject() creates the plasmateprojectrc and not the StartPage::loadLocalProject()

[Aaron J. Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102732/#review8202
-----------------------------------------------------------



startpage.cpp
<http://git.reviewboard.kde.org/r/102732/#comment7025>

    won't this always be the case for a Plasmoid (or other Plasma Package)?
    
    the normal is:
    
    metadata.desktop
    contents/
    
    so ... this will go up one directory when an external project  is loaded and end up in the wrong place. (e.g. an external project is loaded). that looks incorrect.
    
    it should only go up one directory in the case of a plasmate created project, which looks like this on disk:
    
    NOTE
    .plasmaprojectrc
    <nameofproject>/
       \__ metadata.desktop
        |__ contents
    
    i think the real problem here is in trying to autodetect by what is on disk what kind of project it is (created by plasmate, or loaded externally). the easiest way around this, really, is to stop trying to do that and have plasmate simply always point to the directory with the .plasmateprojectrc file.
    
    of course, in the case where is no projectrc file, then the problem remains. instead of having these "dir.cd('..')" checks throughout the code, and constantly having bugs in that code, there should be ONE method somewhere that, given a directory, determines where the root of the project should point to.
    
    this way we can write it once and get it right for all uses.
    
    it may even make sense to simply check and see if the project is in apddata, and if so then we know it is a plasmate created project with that dir structure .. otherwise it is an imported project and to be treated that way.


- Aaron J. Seigo


On Nov. 14, 2011, 8:43 p.m., Giorgos Tsiapaliwkas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102732/
> -----------------------------------------------------------
> 
> (Updated Nov. 14, 2011, 8:43 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Hello,
> 
> for the moment the .plasmateprojectrc file exists as a mark for the projects created by plasmate.
> We want the file to be created in the creation of the project not in the load of the project,the patch does that.
> 
> cheers
> 
> 
> Diffs
> -----
> 
>   mainwindow.cpp 6ea7f0c 
>   startpage.h f16af4b 
>   startpage.cpp 75052b1 
> 
> Diff: http://git.reviewboard.kde.org/r/102732/diff/diff
> 
> 
> Testing
> -------
> 
> workinig
> 
> 
> Thanks,
> 
> Giorgos Tsiapaliwkas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20111115/5fa6edd7/attachment.html>