D15580: [WIP] New annotation toolbar

[Simone Gaiarin]

Sorry for the long silence. I have been busy at work and then on vacation.

Personally I do not like the idea of the vertical toolbar specifically for
Okular for the following reasons:
- Okular differently from Gwenview already has a tab bar, which means that
further splitting the reviews tab into two pieces add another nesting
level.
- Splitting the Review tab horizontally with the toolbar on top and the
reviews below seems quite cluttered to me. Also that review tab could be
improved (see T8553) and may require all the vertical space (e.g. show the
full text of the notes, allow to reply, etc. See Foxit for example).
-  It is not possible to build the toolbar with KXMLGUI as it is now, but
needs to be built programmatically (I think). The Gwenview toolbar is not a
standard toolbar, indeed it cannot be edited or moved.

The reasons for which I prefer to make the annotation toolbar a standard
toolbar displaying only the icons are:
- Many other programs have similar icon-only toolbars (e.g. libreoffice,
and also other PDF viewers e.g. MacOS viewer and Adobe reader). For the
annotation toolbar I would conform with the other PDF viewers.
- The icon buttons have tooltips and likely the users will quickly learn
them
- The toolbar is standard and can be customized by the user.

On Tue, Aug 20, 2019 at 6:26 PM Nathaniel Graham <
noreply at phabricator.kde.org> wrote:

> ngraham added a comment. View Revision
> <https://phabricator.kde.org/D15580>
>
> In D15580#515250 <https://phabricator.kde.org/D15580#515250>, @davidhurka
> <https://phabricator.kde.org/p/davidhurka/> wrote:
>
> In D15580#514707 <https://phabricator.kde.org/D15580#514707>, @ngraham
> <https://phabricator.kde.org/p/ngraham/> wrote:
>
> In D15580#513826 <https://phabricator.kde.org/D15580#513826>, @simgunz
> <https://phabricator.kde.org/p/simgunz/> wrote:
>
>    - How would you fit the annotation actions in the Reviews tab?
>    - Would you create a sub-tab in it (as in Gwenview where the tabs are
>    at the bottom)? -
>    - Can you provide a minimal mockup of this?
>
> Having it tabbed like Gwenview was what I was envisioning, yeah. Basically
> copy the UX of Gwenview's sidebar, but inside Okular's Reviews tab.
>
> I’m not sure whether I understand you. This is a screenshot of the sidebar
> in Gwenview “Operations”. Additionally to the sidebar tab Reviews, you
> want a tab “Add Annotations”, looking like this?
> F7264576: image.png <https://phabricator.kde.org/F7264576>
> Or you want to add a tab bar to the bottom of the Reviews tab, containing
> Annotations and Add Annotations?
> I would simply put the annotation toolbar on top of the Reviews tab, on
> top of the search box. Probably it would cover multiple lines, if that is
> possible with Qt.
>
> Yeah, that might make more sense that having a tabbed view inside the
> review tab. But yes, I was envisioning a vertical toolbar like the above
> screenshot.
>
> *REPOSITORY*
> R223 Okular
>
> *REVISION DETAIL*
> https://phabricator.kde.org/D15580
>
> *To: *simgunz, Okular, VDG
> *Cc: *ltoscano, cfeck, aacid, davidhurka, knambiar, ngraham,
> tobiasdeiminger, okular-devel, maguirre, fbampaloukas, joaonetto, kezik,
> tfella, darcyshen
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20190918/3ae64a19/attachment-0001.html>