D24102: Add Pause/Resume action for pausing and resuming speech synthesis.

Jeremy Whiting noreply at phabricator.kde.org
Mon Oct 7 18:00:35 BST 2019


whiting added a comment.


  In D24102#541529 <https://phabricator.kde.org/D24102#541529>, @whiting wrote:
  
  > In D24102#539859 <https://phabricator.kde.org/D24102#539859>, @sander wrote:
  >
  > > Sorry for being a pain, but your patch contains lots of whitespace changes again (in conf/dlgaccessibilitybase.ui).  I agree that you probably do want them changed, but please do so in a separate patch.
  > >
  > > Besides, can you please post your patch as a merge request on https://invent.kde.org/kde/okular/ ?  That is not purely cosmetic -- invent.kde.org has a CI system.
  > >
  > > Besides that: I like the patch!
  >
  >
  > Ok, I'll fix the whitespace and move it to the other review tool, no problem.
  
  
  Ok, removed whitespace changes that designer did for me and pushed to my clone and created new merge request here: https://invent.kde.org/kde/okular/merge_requests/51

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D24102

To: whiting, aacid
Cc: sander, okular-devel, andisa, siddharthmanthan, maguirre, fbampaloukas, joaonetto, kezik, tfella, ngraham, darcyshen, aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20191007/8105bfd2/attachment.html>


More information about the Okular-devel mailing list