D24102: Add Pause/Resume action for pausing and resuming speech synthesis.

Jeremy Whiting noreply at phabricator.kde.org
Thu Oct 3 16:24:05 BST 2019


whiting added a comment.


  In D24102#539859 <https://phabricator.kde.org/D24102#539859>, @sander wrote:
  
  > Sorry for being a pain, but your patch contains lots of whitespace changes again (in conf/dlgaccessibilitybase.ui).  I agree that you probably do want them changed, but please do so in a separate patch.
  >
  > Besides, can you please post your patch as a merge request on https://invent.kde.org/kde/okular/ ?  That is not purely cosmetic -- invent.kde.org has a CI system.
  >
  > Besides that: I like the patch!
  
  
  Ok, I'll fix the whitespace and move it to the other review tool, no problem.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D24102

To: whiting, aacid
Cc: sander, okular-devel, andisa, siddharthmanthan, maguirre, fbampaloukas, joaonetto, kezik, tfella, ngraham, darcyshen, aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20191003/d3e090fd/attachment.html>


More information about the Okular-devel mailing list