D15580: New annotation toolbar

Yuri Chornoivan noreply at phabricator.kde.org
Sat Nov 2 17:52:13 GMT 2019


yurchor added inline comments.

INLINE COMMENTS

> annotationactionhandler.cpp:387
> +    QAction * aCustomColor = new QAction( QIcon::fromTheme( QStringLiteral("color-picker") ),
> +                                          i18nc("@item:inlistbox", "Custom Color.."), q );
> +    aColorPicker->addAction( aCustomColor );

May it be a complete ellipsis, for consistency (.. -> ...)?

REPOSITORY
  R223 Okular

BRANCH
  new-annotation-toolbar_ToggleActionMenu

REVISION DETAIL
  https://phabricator.kde.org/D15580

To: simgunz, #okular, #vdg, ngraham
Cc: andreashurka, yurchor, trickyricky26, simgunz, ltoscano, cfeck, aacid, davidhurka, knambiar, ngraham, tobiasdeiminger, okular-devel, johnzh, andisa, siddharthmanthan, maguirre, fbampaloukas, joaonetto, kezik, tfella, darcyshen
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20191102/1955eb80/attachment-0001.html>


More information about the Okular-devel mailing list