D21332: Okular Annotation: add line start/end style config only for Straight Line tool

Fri May 24 06:45:17 BST 2019

knambiar added inline comments.

INLINE COMMENTS

> tobiasdeiminger wrote in annotationwidgets.cpp:499
> Checking a polygons Inner color checkbox now causes segfault. It's because `LineAnnotationWidget::applyChanges` accesses `m_startStyleCombo` and `m_endStyleCombo` unconditionally. But in case of `m_lineType == 1` that QComboBoxes have never been constructed. Access should be guarded by `if ( m_lineType == 0 )`, and probably an additional `nullptr` check.

Is the `nullptr` check really necessary?

> tobiasdeiminger wrote in annotationwidgets.cpp:528
> Are the leading whitespaces in " Square", " Circle", and so on, intentional?

No, it was an oversight from previous local patch. Fixed now.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D21332

To: knambiar, #okular
Cc: tobiasdeiminger, okular-devel, joaonetto, tfella, ngraham, darcyshen, aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20190524/75cbed34/attachment-0001.html>