D15580: New annotation toolbar

[Simone Gaiarin]

simgunz updated this revision to Diff 59781.
simgunz added a comment.


  Changes:
  
  - Added opacity action
  - Cleaned width action
  - Big code refactor:
    - m_toolDefinition is now a QDomDocument, so that the toolElement are not randomly deleted when the associated QDomDocument goes out of scope.
    - AnnotationActionHandler acts directly on PageViewAnnotator instead of emitting signals
  - Further code cleaning in pageview.cpp
  - Annotations work only in Normal mouse mode, and switch to it when they are selected
  
  Commits:
  
  - Remove unused variable
  - Remove tooltips that are never shown in any case
  - Add width action icons
  - Use KToggleAction
  - Make m_toolsDefinition a QDomDocument
  - Remove unused method
  - Refactor code and remove obsolete code
  - Detach annotation when mouse mode is not Normal mode
  - Use Qt5 connect syntax where possible
  - Add Advanced Settings dialog
  - Set better action names
  - Add opacity selection action
  - Fix width text
  
  Code is still messy in some parts, I'll clean it at the end.

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15580?vs=59208&id=59781

BRANCH
  annotation-toolbar-stable

REVISION DETAIL
  https://phabricator.kde.org/D15580

AFFECTED FILES
  CMakeLists.txt
  part.rc
  ui/annotationactionhandler.cpp
  ui/annotationactionhandler.h
  ui/data/tools.xml
  ui/pageview.cpp
  ui/pageview.h
  ui/pageviewannotator.cpp
  ui/pageviewannotator.h
  ui/pageviewutils.cpp
  ui/pageviewutils.h
  ui/toolaction.cpp

To: simgunz, #okular
Cc: aacid, anthonyfieroni, davidhurka, knambiar, ngraham, tobiasdeiminger, okular-devel, joaonetto, tfella, darcyshen
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20190614/5c4a4c97/attachment-0001.html>