D15580: New annotation toolbar

[Albert Astals Cid]

aacid added inline comments.

INLINE COMMENTS

> annotationactionhandler.cpp:131
> +    // Text markup
> +    QAction * annHighlighter  = new QAction(QIcon::fromTheme( QStringLiteral("draw-eraser") ), "Highlighter", this);
> +    annHighlighter->setCheckable( true );

no i18n?

> simgunz wrote in pageview.cpp:665
> Is it there a clean way to obtain a reference to the toolbar from within this class?
> I guess that KMainWindow::toolBar(name) is a possibility, but how do I get a reference to the main window?

right, that's actually a tricky question.

I'll try to figure it out, but you may want to play with stuff and not wait for me, a close friend of mine is getting married so don't expect anything from me until monday/tuesday

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D15580

To: simgunz, #okular
Cc: aacid, anthonyfieroni, davidhurka, knambiar, ngraham, tobiasdeiminger, okular-devel, joaonetto, tfella, darcyshen
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20190613/f56996cf/attachment-0001.html>