D21755: Replace ToolAction by a more universal “ToggleActionMenu”

[Albert Astals Cid]

aacid added inline comments.

INLINE COMMENTS

> davidhurka wrote in toggleactionmenu.h:24
> > Destructors are cascaded adding a destructor won't make the parent class destructor not be called anymore.
> 
> Makes sense, so I will add a virtual destructor.
> 
> As far as i know, a class gets a “normal” destructor, if no one is declared explicitely.

But that's what i'm saying you don't need to add a virtual destructor because it inherits from QObject

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D21755

To: davidhurka, #okular
Cc: aacid, #vdg, okular-devel, joaonetto, tfella, ngraham, darcyshen
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20190611/50e7a0d9/attachment.html>