D21755: Replace ToolAction by a more universal “ToggleActionMenu”

[David Hurka]

davidhurka added inline comments.

INLINE COMMENTS

> aacid wrote in toggleactionmenu.h:24
> What do you mean "breaking the destructor"?
> 
> Destructors are cascaded adding a destructor won't make the parent class destructor not be called anymore.
> 
> I don't  see why you should get this wanrning
> 
> KActionMenu ends up inheriting from QObject that has a virtual destructor, so you shouldn't be getting that warning at all
> 
> Actually i don't get it

> Destructors are cascaded adding a destructor won't make the parent class destructor not be called anymore.

Makes sense, so I will add a virtual destructor.

As far as i know, a class gets a “normal” destructor, if no one is declared explicitely.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D21755

To: davidhurka, #okular
Cc: aacid, #vdg, okular-devel, joaonetto, tfella, ngraham, darcyshen
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20190611/3b860023/attachment.html>