D15580: New annotation toolbar

[Simone Gaiarin]

simgunz added a comment.


  I renamed PageViewToolBar and moved to a file by itself. I took inspiration from Dolphin for the name.
  
  There is still code to be cleaned though.

INLINE COMMENTS

> pageview.cpp:665
>  
> -    d->aToggleAnnotator  = new KToggleAction(QIcon::fromTheme( QStringLiteral("draw-freehand") ), i18n("&Review"), this);
> +    d->aToggleAnnotator = new KToggleToolBarAction( "annotationToolBar", i18n("&Review"), this); //FIXME: Not working
> +    d->aToggleAnnotator->setIcon( QIcon::fromTheme( QStringLiteral("draw-freehand") ) );

Anyone knows how KToggleToolBarAction is supposed to work?

Currently it does nothing.

Reading the code, it seems that the constructor where the toolbar is specified by name does nothing, unless there is some other magic going on.
https://api.kde.org/frameworks/kxmlgui/html/ktoggletoolbaraction_8cpp_source.html#l00061

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D15580

To: simgunz, #okular
Cc: anthonyfieroni, davidhurka, knambiar, ngraham, tobiasdeiminger, okular-devel, joaonetto, tfella, darcyshen, aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20190605/e07ae70d/attachment-0001.html>