<table><tr><td style="">simgunz added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D15580">View Revision</a></tr></table><br /><div><div><p>I renamed PageViewToolBar and moved to a file by itself. I took inspiration from Dolphin for the name.</p>

<p>There is still code to be cleaned though.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D15580#inline-121445">View Inline</a><span style="color: #4b4d51; font-weight: bold;">pageview.cpp:665</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="n">d</span><span style="color: #aa2211">-></span><span class="n">aToggleAnnotator</span> <span class="bright"> </span><span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span class="n">KToggleAction</span><span class="p">(<span class="bright"></span></span><span class="bright"></span><span class="n"><span class="bright">QIcon</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">fromTheme</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"> </span><span class="n"><span class="bright">QStringLiteral</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"draw-freehand"</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span><span class="bright"> </span><span class="p"><span class="bright">)</span>,</span> <span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"&Review"</span><span class="p">),</span> <span style="color: #aa4000">this</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">d</span><span style="color: #aa2211">-></span><span class="n">aToggleAnnotator</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span class="n">KToggle<span class="bright">ToolBar</span>Action</span><span class="p">(<span class="bright"></span></span><span class="bright"> </span><span style="color: #766510"><span class="bright">"annotationToolBar"</span></span><span class="p">,</span> <span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"&Review"</span><span class="p">),</span> <span style="color: #aa4000">this</span><span class="p">);<span class="bright"></span></span><span class="bright"> </span><span style="color: #74777d"><span class="bright">//FIXME: Not working</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">d</span><span style="color: #aa2211">-></span><span class="n">aToggleAnnotator</span><span style="color: #aa2211">-></span><span class="n">setIcon</span><span class="p">(</span> <span class="n">QIcon</span><span style="color: #aa2211">::</span><span class="n">fromTheme</span><span class="p">(</span> <span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"draw-freehand"</span><span class="p">)</span> <span class="p">)</span> <span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Anyone knows how KToggleToolBarAction is supposed to work?</p>

<p style="padding: 0; margin: 8px;">Currently it does nothing.</p>

<p style="padding: 0; margin: 8px;">Reading the code, it seems that the constructor where the toolbar is specified by name does nothing, unless there is some other magic going on.<br />
<a href="https://api.kde.org/frameworks/kxmlgui/html/ktoggletoolbaraction_8cpp_source.html#l00061" class="remarkup-link" target="_blank" rel="noreferrer">https://api.kde.org/frameworks/kxmlgui/html/ktoggletoolbaraction_8cpp_source.html#l00061</a></p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R223 Okular</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D15580">https://phabricator.kde.org/D15580</a></div></div><br /><div><strong>To: </strong>simgunz, Okular<br /><strong>Cc: </strong>anthonyfieroni, davidhurka, knambiar, ngraham, tobiasdeiminger, okular-devel, joaonetto, tfella, darcyshen, aacid<br /></div>