D15580: New annotation toolbar

[Simone Gaiarin]

simgunz added a comment.


  If we remove the sticky button, we have two options:
  
  - set sticky by default, we will make some users that use the non-sticky mode unhappy
  - set non-sticky by default and use double click to stick, we go back to the current situation (bug 358057)
  
  I we keep the sticky button, the double click to stick becomes pretty irrelevant.
  
  To sum up, I would:
  
  - keep the sticky button to make the feature clearly visible to the user (see bug 358057). As it is now this feature is hard to discover, took me years to figure it exists.
  - make the tool sticky by default on first installation, then save the state of the sticky button (if a user prefer non-sticky annotation, after unchecking the sticky button he will have it unchecked when he relaunch Okular)
  - disable annotation on right click anywhere (as current Okular)
  - disable annotation on left click on annotation (as current Okular) [ I have sent a patch to Qt to modify QActionGroup, https://codereview.qt-project.org/c/qt/qtbase/+/255770)
  - disable annotation on Esc (as current Okular)
  
  Foxit reader has a "Pin" button. How is it implemented in other readers?

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D15580

To: simgunz, #okular
Cc: anthonyfieroni, davidhurka, knambiar, ngraham, tobiasdeiminger, okular-devel, joaonetto, tfella, darcyshen, aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20190604/7b118311/attachment.html>