D10048: [PATCH 2/4] Add refresh widgets if underlying field changes

[Albert Astals Cid]

aacid added inline comments.

INLINE COMMENTS

> document.cpp:1153
> +                                    fft->setText( newVal );
> +                                    emit m_parent->refreshFormWidget( fft );
> +                                    pageNeedsRefresh = true;

I was thinking, can't we do setText emit the signal? so we don't really need to worry about forgetting to emit refreshFormWidget in case we end up implementing another function or something that does change the text of a form?

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D10048

To: aheinecke, #okular
Cc: aacid, michaelweghorn, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20180209/6d50f7b7/attachment-0001.html>