<table><tr><td style="">aacid added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D10048" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D10048#inline-48804" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">document.cpp:1153</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                                    <span class="n">fft</span><span style="color: #aa2211">-></span><span class="n">setText</span><span class="p">(</span> <span class="n">newVal</span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                                    <span class="n">emit</span> <span class="n">m_parent</span><span style="color: #aa2211">-></span><span class="n">refreshFormWidget</span><span class="p">(</span> <span class="n">fft</span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                                    <span class="n">pageNeedsRefresh</span> <span style="color: #aa2211">=</span> <span style="color: #304a96">true</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I was thinking, can't we do setText emit the signal? so we don't really need to worry about forgetting to emit refreshFormWidget in case we end up implementing another function or something that does change the text of a form?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R223 Okular</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D10048" rel="noreferrer">https://phabricator.kde.org/D10048</a></div></div><br /><div><strong>To: </strong>aheinecke, Okular<br /><strong>Cc: </strong>aacid, michaelweghorn, ngraham<br /></div>