[Okular-devel] Review Request: Default settings file is separated in two files corresponding to the back end and the front end

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104947/#review14866
-----------------------------------------------------------


Why did you add a new patch file instead of updating the review request? It makes it kind of difficult to continue the review if we have the code splitting in two different places, can you update the review request patch, please?

- Albert Astals Cid


On June 17, 2012, 10:27 p.m., Bogdan Cristea wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104947/
> -----------------------------------------------------------
> 
> (Updated June 17, 2012, 10:27 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Description
> -------
> 
> Default settings file should be separated in two different files in order to have a better separation between okular core library (back end) and the front end (https://bugs.kde.org/show_bug.cgi?id=299526). This review request includes only the separation of okular.kcfg in two files:
> -okular.kcfg (front end)
> -okular_core.kcfg (back end)
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 0034cf3 
>   conf/okular.kcfg 6ad0e19 
>   conf/okular_core.kcfg PRE-CREATION 
>   conf/settings.kcfgc 0b70390 
>   conf/settings_core.kcfgc PRE-CREATION 
>   core/document.cpp 0ebc34e 
>   core/script/kjs_fullscreen.cpp c07ac4e 
>   core/texteditors_p.h 171dc69 
>   okular.spec PRE-CREATION 
>   part.cpp 4c6aac8 
>   ui/pagepainter.cpp ca55e81 
>   ui/pageview.cpp 4be5e6b 
>   ui/presentationwidget.cpp a3b8be4 
> 
> Diff: http://git.reviewboard.kde.org/r/104947/diff/
> 
> 
> Testing
> -------
> 
> No
> 
> 
> Thanks,
> 
> Bogdan Cristea
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20120618/5a3a8711/attachment.html>