<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104947/">http://git.reviewboard.kde.org/r/104947/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Why did you add a new patch file instead of updating the review request? It makes it kind of difficult to continue the review if we have the code splitting in two different places, can you update the review request patch, please?</pre>
<br />
<p>- Albert</p>
<br />
<p>On June 17th, 2012, 10:27 p.m., Bogdan Cristea wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Okular.</div>
<div>By Bogdan Cristea.</div>
<p style="color: grey;"><i>Updated June 17, 2012, 10:27 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Default settings file should be separated in two different files in order to have a better separation between okular core library (back end) and the front end (https://bugs.kde.org/show_bug.cgi?id=299526). This review request includes only the separation of okular.kcfg in two files:
-okular.kcfg (front end)
-okular_core.kcfg (back end)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">No</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(0034cf3)</span></li>
<li>conf/okular.kcfg <span style="color: grey">(6ad0e19)</span></li>
<li>conf/okular_core.kcfg <span style="color: grey">(PRE-CREATION)</span></li>
<li>conf/settings.kcfgc <span style="color: grey">(0b70390)</span></li>
<li>conf/settings_core.kcfgc <span style="color: grey">(PRE-CREATION)</span></li>
<li>core/document.cpp <span style="color: grey">(0ebc34e)</span></li>
<li>core/script/kjs_fullscreen.cpp <span style="color: grey">(c07ac4e)</span></li>
<li>core/texteditors_p.h <span style="color: grey">(171dc69)</span></li>
<li>okular.spec <span style="color: grey">(PRE-CREATION)</span></li>
<li>part.cpp <span style="color: grey">(4c6aac8)</span></li>
<li>ui/pagepainter.cpp <span style="color: grey">(ca55e81)</span></li>
<li>ui/pageview.cpp <span style="color: grey">(4be5e6b)</span></li>
<li>ui/presentationwidget.cpp <span style="color: grey">(a3b8be4)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104947/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>