D26764: Another revert to unbreak crash fix

[Konstantin Kharlamov]

kkharlamov added a comment.


  > This breaks the logic for the KDBusService crash fix. If this (using unique_ptr)
  >  needs to be done it needs to carefully release() and reset() at every step, and
  >  then it's just easier to manually delete it where appropriate IMHO.
  
  Hi! Sorry, could you please elaborate why does it break the logic? Behavior of the code before and after the change should be the same because `unique_ptr` calls `delete app` upon going out of scope.

REPOSITORY
  R319 Konsole

REVISION DETAIL
  https://phabricator.kde.org/D26764

To: sandsmark, #konsole, hindenburg, kkharlamov
Cc: konsole-devel, hindenburg, #konsole, hiangel, cent, EspadaV8, fbampaloukas, thsurrel, ngraham, maximilianocuria
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20200119/398d4fdb/attachment-0001.html>