D26764: Another revert to unbreak crash fix

Martin Tobias Holmedahl Sandsmark noreply at phabricator.kde.org
Sun Jan 19 13:12:36 GMT 2020


sandsmark created this revision.
sandsmark added reviewers: Konsole, hindenburg, kkharlamov.
sandsmark added a project: Konsole.
Herald added a subscriber: konsole-devel.
sandsmark requested review of this revision.

REVISION SUMMARY
  Revert "Use RAII to manage QApplication memory"
  
  This breaks the logic for the KDBusService crash fix. If this (using
  unique_ptr) needs to be done it needs to carefully release() and reset()
  at every step, and then it's just easier to manually delete it where
  appropriate IMHO.
  
  This reverts commit d5d8496cd285cf988884e99d29d76367cfcd742f <https://phabricator.kde.org/R319:d5d8496cd285cf988884e99d29d76367cfcd742f>.

REPOSITORY
  R319 Konsole

REVISION DETAIL
  https://phabricator.kde.org/D26764

AFFECTED FILES
  src/main.cpp

To: sandsmark, #konsole, hindenburg, kkharlamov
Cc: konsole-devel, hindenburg, #konsole, hiangel, cent, EspadaV8, fbampaloukas, thsurrel, ngraham, maximilianocuria
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20200119/b32326a1/attachment.html>


More information about the konsole-devel mailing list