D20816: [WIP] Configure Konsole dialog GUI redesign

[Mariusz Glebocki]

mglb created this revision.
mglb added reviewers: Konsole, VDG.
mglb added projects: Konsole, VDG.
Herald added a subscriber: konsole-devel.
mglb requested review of this revision.

REVISION SUMMARY
  - Extensions/workarounds for KF5 classes - I'll fix the classes in KF5 later. This allows to make it work for now.
    - Create new KConfigDialog-like class and use it to show existing configuration pages.
    - Create KConfigDialogManager-like class for managing QButtonGroups
  
  - Remove help button from configuration dialog. There is nothing about configuration dialog options in the help.
  
  - Rename "File Location" to "Temporary Files" - this page probably will be removed (D20466 <https://phabricator.kde.org/D20466>)
    - Enable path selector only when "custom" is selected
    - Place paths directly in labels
  
  - Disable all tabbar settings except visibility when visibility is set to "Never"
  
  - Profile Settings
    - Use QTreeView instead of QTableView - it highlights whole lines, aligns header names to the left, etc. Basically it looks like lists in file manager or e.g. plugin list in Kate.
    - Use (default) QStyledItemDelegate with checkbox instead of custom delegate (tick mark) in favorite/show column. I like this look, but there is a task to standardize list views, so it will probably be changed in future anyway (T10384 <https://phabricator.kde.org/T10384>)
    - Change default profile item style - it now has italics font and "(default)" suffix.
    - Disable "Delete" button when default profile is selected
  
  - Minor string changes
  
  **TODO**
  
  - Profile lists changes (show/hide, remove and maybe create) should be applied after clicking apply or ok. This will make it consistent with other options, and make accidental profile removal reversible
  - Experiment with embedded edit profile dialog on profiles page and see if it makes sense
  - Cleanup
  
  Create and integrate new configuration dialog class
  
  Create new KConfigDialog-like class and use it to show existing
  configuration pages.
  
  Remove help button from configuration dialog
  
  There is nothing about configuration dialog options in the help.
  
  Redesign UI
  
  Rename "File Location" to "Temporary Files"
  
  Enable path selector only when "custom" is selected
  
  TemporaryFilesSettings: place paths directly in labels
  
  Misc
  
  Enable/disable tabbar settings
  
  Disable all tabbar settings except visibility when visibility is set
  to "Never"
  
  Redesign Profile Settings
  
  - Use QTreeView instead of QTableView - it highlights whole lines, aligns header names to the left, etc. Basically it looks like lists in file manager or e.g. plugin list in Kate.
  - Use (default) QStyledItemDelegate with checkbox instead of custom delegate (tick mark) in "favorite" column.
  - Move "favorite" column before name column, change its meaning to "Show profile in menu".
  - Change default profile item style - it now has italics font and "(default)" suffix.
  
  Disable "Delete" button when default profile is selected

REPOSITORY
  R319 Konsole

BRANCH
  wip/Configure-Konsole-dialog-GUI-redesing (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20816

AFFECTED FILES
  src/CMakeLists.txt
  src/MainWindow.cpp
  src/settings/ConfigurationDialog.cpp
  src/settings/ConfigurationDialog.h
  src/settings/FileLocationSettings.cpp
  src/settings/FileLocationSettings.h
  src/settings/FileLocationSettings.ui
  src/settings/GeneralSettings.ui
  src/settings/ProfileSettings.cpp
  src/settings/ProfileSettings.h
  src/settings/ProfileSettings.ui
  src/settings/TabBarSettings.cpp
  src/settings/TabBarSettings.ui
  src/settings/TemporaryFilesSettings.cpp
  src/settings/TemporaryFilesSettings.h
  src/settings/TemporaryFilesSettings.ui

To: mglb, #konsole, #vdg
Cc: #vdg, konsole-devel, #konsole, cblack, arvidhansson, ian, jguidon, hannahk, Pixel_Lime, jraleigh, gennad, squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, thsurrel, mglb, crozbo, ndavis, firef, ngraham, skadinna, maximilianocuria, aaronhoneycutt, hindenburg, mbohlender
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20190425/ca7b0c59/attachment.html>