<table><tr><td style="">mglb created this revision.<br />mglb added reviewers: Konsole, VDG.<br />mglb added projects: Konsole, VDG.<br />Herald added a subscriber: konsole-devel.<br />mglb requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D20816">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><ul class="remarkup-list">
<li class="remarkup-list-item">Extensions/workarounds for KF5 classes - I'll fix the classes in KF5 later. This allows to make it work for now.<ul class="remarkup-list">
<li class="remarkup-list-item">Create new KConfigDialog-like class and use it to show existing configuration pages.</li>
<li class="remarkup-list-item">Create KConfigDialogManager-like class for managing QButtonGroups</li>
</ul></li>
</ul>
<ul class="remarkup-list">
<li class="remarkup-list-item">Remove help button from configuration dialog. There is nothing about configuration dialog options in the help.</li>
</ul>
<ul class="remarkup-list">
<li class="remarkup-list-item">Rename "File Location" to "Temporary Files" - this page probably will be removed (<a href="https://phabricator.kde.org/D20466" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D20466</a>)<ul class="remarkup-list">
<li class="remarkup-list-item">Enable path selector only when "custom" is selected</li>
<li class="remarkup-list-item">Place paths directly in labels</li>
</ul></li>
</ul>
<ul class="remarkup-list">
<li class="remarkup-list-item">Disable all tabbar settings except visibility when visibility is set to "Never"</li>
</ul>
<ul class="remarkup-list">
<li class="remarkup-list-item">Profile Settings<ul class="remarkup-list">
<li class="remarkup-list-item">Use QTreeView instead of QTableView - it highlights whole lines, aligns header names to the left, etc. Basically it looks like lists in file manager or e.g. plugin list in Kate.</li>
<li class="remarkup-list-item">Use (default) QStyledItemDelegate with checkbox instead of custom delegate (tick mark) in favorite/show column. I like this look, but there is a task to standardize list views, so it will probably be changed in future anyway (<a href="https://phabricator.kde.org/T10384" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">T10384</a>)</li>
<li class="remarkup-list-item">Change default profile item style - it now has italics font and "(default)" suffix.</li>
<li class="remarkup-list-item">Disable "Delete" button when default profile is selected</li>
</ul></li>
</ul>
<ul class="remarkup-list">
<li class="remarkup-list-item">Minor string changes</li>
</ul>
<p><strong>TODO</strong></p>
<ul class="remarkup-list">
<li class="remarkup-list-item">Profile lists changes (show/hide, remove and maybe create) should be applied after clicking apply or ok. This will make it consistent with other options, and make accidental profile removal reversible</li>
<li class="remarkup-list-item">Experiment with embedded edit profile dialog on profiles page and see if it makes sense</li>
<li class="remarkup-list-item">Cleanup</li>
</ul>
<p>Create and integrate new configuration dialog class</p>
<p>Create new KConfigDialog-like class and use it to show existing<br />
configuration pages.</p>
<p>Remove help button from configuration dialog</p>
<p>There is nothing about configuration dialog options in the help.</p>
<p>Redesign UI</p>
<p>Rename "File Location" to "Temporary Files"</p>
<p>Enable path selector only when "custom" is selected</p>
<p>TemporaryFilesSettings: place paths directly in labels</p>
<p>Misc</p>
<p>Enable/disable tabbar settings</p>
<p>Disable all tabbar settings except visibility when visibility is set<br />
to "Never"</p>
<p>Redesign Profile Settings</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">Use QTreeView instead of QTableView - it highlights whole lines, aligns header names to the left, etc. Basically it looks like lists in file manager or e.g. plugin list in Kate.</li>
<li class="remarkup-list-item">Use (default) QStyledItemDelegate with checkbox instead of custom delegate (tick mark) in "favorite" column.</li>
<li class="remarkup-list-item">Move "favorite" column before name column, change its meaning to "Show profile in menu".</li>
<li class="remarkup-list-item">Change default profile item style - it now has italics font and "(default)" suffix.</li>
</ul>
<p>Disable "Delete" button when default profile is selected</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R319 Konsole</div></div></div><br /><div><strong>BRANCH</strong><div><div>wip/Configure-Konsole-dialog-GUI-redesing (branched from master)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D20816">https://phabricator.kde.org/D20816</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>src/CMakeLists.txt<br />
src/MainWindow.cpp<br />
src/settings/ConfigurationDialog.cpp<br />
src/settings/ConfigurationDialog.h<br />
src/settings/FileLocationSettings.cpp<br />
src/settings/FileLocationSettings.h<br />
src/settings/FileLocationSettings.ui<br />
src/settings/GeneralSettings.ui<br />
src/settings/ProfileSettings.cpp<br />
src/settings/ProfileSettings.h<br />
src/settings/ProfileSettings.ui<br />
src/settings/TabBarSettings.cpp<br />
src/settings/TabBarSettings.ui<br />
src/settings/TemporaryFilesSettings.cpp<br />
src/settings/TemporaryFilesSettings.h<br />
src/settings/TemporaryFilesSettings.ui</div></div></div><br /><div><strong>To: </strong>mglb, Konsole, VDG<br /><strong>Cc: </strong>VDG, konsole-devel, Konsole, cblack, arvidhansson, ian, jguidon, hannahk, Pixel_Lime, jraleigh, gennad, squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, thsurrel, mglb, crozbo, ndavis, firef, ngraham, skadinna, maximilianocuria, aaronhoneycutt, hindenburg, mbohlender<br /></div>