[Differential] [Accepted] D4032: Remove support for splash screen from Core::initialize(...)

[Kevin Funk]

kfunk accepted this revision.
kfunk added a reviewer: kfunk.
kfunk added a comment.
This revision is now accepted and ready to land.


  Rest LGTM. Should go to master branch.

INLINE COMMENTS

> core.cpp:320
>  {
> +    if( splash ) {
> +        QTimer::singleShot( 200, splash, SLOT(deleteLater()) );

Style: No spaces in `(...)`

> core.h:66
> +    static bool initialize(Setup mode=Default, const QString& session = {});
> +    // TODO: remove before 5.1 release
> +    static QT_DEPRECATED bool initialize(QObject* splash = nullptr, Setup mode=Default, const QString& session = {});

Should be before '5.2 release', no?

This patch should go to master branch

REPOSITORY
  R33 KDevPlatform

BRANCH
  removeLastSplashCode

REVISION DETAIL
  https://phabricator.kde.org/D4032

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: kossebau, #kdevelop, kfunk
Cc: kfunk, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170109/f7c3b166/attachment.html>