<table><tr><td style="">kfunk accepted this revision.<br />kfunk added a reviewer: kfunk.<br />kfunk added a comment.<br />This revision is now accepted and ready to land.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D4032" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>Rest LGTM. Should go to master branch.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D4032#inline-15939" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">core.cpp:320</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "><span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">    <span style="color: #aa4000">if</span><span class="p">(</span> <span class="n">splash</span> <span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">        <span class="n">QTimer</span><span style="color: #aa2211">::</span><span class="n">singleShot</span><span class="p">(</span> <span style="color: #601200">200</span><span class="p">,</span> <span class="n">splash</span><span class="p">,</span> <span class="n">SLOT</span><span class="p">(</span><span class="n">deleteLater</span><span class="p">())</span> <span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Style: No spaces in <tt style="background: #ebebeb; font-size: 13px;">(...)</tt></p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D4032#inline-15938" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">core.h:66</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;">    <span style="color: #aa4000">static</span> <span style="color: #aa4000">bool</span> <span style="color: #004012">initialize</span><span class="p">(<span class="bright"></span></span><span class="bright"></span><span class="n"><span class="bright">QObject</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">*</span></span><span class="bright"> </span><span class="n"><span class="bright">splash</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">=</span></span><span class="bright"> </span><span class="n"><span class="bright">nullptr</span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span><span class="bright"> </span><span class="n">Setup</span> <span class="n">mode</span><span style="color: #aa2211">=</span><span class="n">Default</span><span class="p">,</span> <span style="color: #aa4000">const</span> <span class="n">QString</span><span style="color: #aa2211">&</span> <span class="n">session</span> <span style="color: #aa2211">=</span> <span class="p">{}<span class="bright"></span></span><span class="bright"> </span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">    <span style="color: #aa4000">static</span> <span style="color: #aa4000">bool</span> <span style="color: #004012">initialize</span><span class="p">(</span><span class="n">Setup</span> <span class="n">mode</span><span style="color: #aa2211">=</span><span class="n">Default</span><span class="p">,</span> <span style="color: #aa4000">const</span> <span class="n">QString</span><span style="color: #aa2211">&</span> <span class="n">session</span> <span style="color: #aa2211">=</span> <span class="p">{});</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">    <span style="color: #74777d">// TODO: remove before 5.1 release</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">    <span style="color: #aa4000">static</span> <span class="n">QT_DEPRECATED</span> <span style="color: #aa4000">bool</span> <span style="color: #004012">initialize</span><span class="p">(</span><span class="n">QObject</span><span style="color: #aa2211">*</span> <span class="n">splash</span> <span style="color: #aa2211">=</span> <span class="n">nullptr</span><span class="p">,</span> <span class="n">Setup</span> <span class="n">mode</span><span style="color: #aa2211">=</span><span class="n">Default</span><span class="p">,</span> <span style="color: #aa4000">const</span> <span class="n">QString</span><span style="color: #aa2211">&</span> <span class="n">session</span> <span style="color: #aa2211">=</span> <span class="p">{});</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Should be before '5.2 release', no?</p>

<p style="padding: 0; margin: 8px;">This patch should go to master branch</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R33 KDevPlatform</div></div></div><br /><div><strong>BRANCH</strong><div><div>removeLastSplashCode</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D4032" rel="noreferrer">https://phabricator.kde.org/D4032</a></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>kossebau, KDevelop, kfunk<br /><strong>Cc: </strong>kfunk, kdevelop-devel<br /></div>