Review Request 119338: Port from KMimeType to QMimeType

[Kevin Funk]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119338/#review62868
-----------------------------------------------------------

Ship it!


Nice work!


shell/languagecontroller.cpp
<https://git.reviewboard.kde.org/r/119338/#comment43587>

    Use QMultiHash instead.
    
    We should never depend on the order here.



shell/languagecontroller.cpp
<https://git.reviewboard.kde.org/r/119338/#comment43588>

    Nitpick: Space after 'if'


- Kevin Funk


On July 17, 2014, 2:42 p.m., Alexander Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119338/
> -----------------------------------------------------------
> 
> (Updated July 17, 2014, 2:42 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> Port from KMimeType to QMimeType
> 
> 
> Diffs
> -----
> 
>   shell/settings/sourceformattersettings.cpp 67b0b6e5cadc6e74d4b1f04e7233fb0499a5309e 
>   shell/sourceformattercontroller.h 2e52884b58aa0b7ad0bc417893270ae02036258f 
>   shell/sourceformattercontroller.cpp cb44ac55ef432c3f8f68f4b4ac3aa1386ceec0df 
>   shell/textdocument.cpp 3e67236f4e2a6989f83700ddf0a3ba40ddd3a76f 
>   vcs/models/vcsfilechangesmodel.cpp c3b1afe1a9471d1d9a17d4c69d4d767fccc7eb45 
>   vcs/models/vcsitemeventmodel.cpp b5de0b1bb6903b565c6b1a0c856176a918247212 
>   debugger/framestack/framestackmodel.cpp 231df7b457c05724e75306abd0a726e495fd7ade 
>   interfaces/context.h 6ffccf2543ebadde08272eed7be0b231561233f7 
>   interfaces/context.cpp 37bc6969a69a58afe7012254dcc199cb13a7011a 
>   interfaces/idocument.h 59fe09937d084f5fe88a1815bb90bd6907781746 
>   interfaces/isourceformatter.h cc0a50da54b417ac37c8ee1472722e9c3b2cb785 
>   interfaces/isourceformatter.cpp 53946110a7c7555ada6cf6a4f6697a0f799f674c 
>   interfaces/isourceformattercontroller.h cc8d1ef99dfaf361f8c284892175cfe32f37b0eb 
>   language/codegen/applychangeswidget.cpp 8bd26206a38223158142867127d873986faf2630 
>   language/codegen/documentchangeset.cpp 883e537dedf0977f1195557cf4ed2d87fb156ca7 
>   shell/documentcontroller.cpp ac5150860cf0ca41d40a0e51b6d3d16a31369441 
>   shell/languagecontroller.cpp 9ec664d152702e0f42cca8a8f1436ad51e3209e3 
>   shell/partcontroller.h 04b29b30b230052b165dda835195a0edcb3ee1b3 
>   shell/partcontroller.cpp cb42ce7e0c24c6fa3036a00bfeb29ca92edada0a 
>   shell/partdocument.h 2e44c74becc50041491fc9ccf1315d44c9de6529 
>   shell/partdocument.cpp 6330b1e668b6bac7b9353ebd105172322fcb8aeb 
>   shell/settings/editstyledialog.h 50188cae983dbeb2bf00afd3224f4678a005bccc 
>   shell/settings/editstyledialog.cpp c9fdfb02df15984fe429d5c191fe78fc0aa0492b 
>   shell/settings/sourceformattersettings.h a46287579fa2d025878b2b1fe002fad35496173e 
>   plugins/appwizard/appwizardplugin.cpp 8e9a001094245c27d54171c57f7e9b62abe05f58 
>   plugins/dashboard/dashboarddocument.h b63f343aa4162510075378ebb98854f1814a4b8c 
>   plugins/dashboard/dashboarddocument.cpp e48d83341603283db58512186c1f21f0d7764616 
>   plugins/executescript/scriptappconfig.cpp e6ec5badbc34e4e9d34a67bb38c087554056df73 
>   plugins/grepview/grepviewplugin.cpp 3709dab63a929f54ee859ca22c5a5487c1eec839 
>   plugins/openwith/openwithplugin.cpp f9f9e219fde69ead430c58480b90373aed722b3f 
>   plugins/reviewboard/reviewboardjobs.cpp 2fe2ca78366217842cfa1ee226714a23cd99c5f6 
>   plugins/switchtobuddy/switchtobuddyplugin.cpp 6003b304a39d7a37a9b5c5562780803609b524df 
>   project/projectmodel.cpp 74ea6aa604410b46b00b66d0aa65710e5bbc18e8 
>   project/tests/projectmodeltest.cpp 2236a4985d5bd971620c3d26bdfa02e27923c490 
>   language/codegen/templatesmodel.cpp 6d302f026dbfdd47fc93dc531521585af53e1bb7 
> 
> Diff: https://git.reviewboard.kde.org/r/119338/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140722/29602a22/attachment-0001.html>