<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119338/">https://git.reviewboard.kde.org/r/119338/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Nice work!</p></pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/119338/diff/1/?file=290857#file290857line100" style="color: black; font-weight: bold; text-decoration: underline;">shell/languagecontroller.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">struct LanguageControllerPrivate {</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">93</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">typedef</span> <span class="n">QMultiMap</span><span class="o"><</span><span class="n"><span class="hl">K</span>MimeType</span><span class="o"><span class="hl">::</span></span><span class="n"><span class="hl">Ptr</span></span><span class="p">,</span> <span class="n">ILanguage</span><span class="o">*></span> <span class="n">MimeTypeCache</span><span class="p">;</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">98</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">typedef</span> <span class="n">QMultiMap</span><span class="o"><</span><span class="n"><span class="hl">Q</span>MimeType</span><span class="p">,</span> <span class="n">ILanguage</span><span class="o">*></span> <span class="n">MimeTypeCache</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Use QMultiHash instead.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">We should never depend on the order here.</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/119338/diff/1/?file=290857#file290857line308" style="color: black; font-weight: bold; text-decoration: underline;">shell/languagecontroller.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">QList<ILanguage*> LanguageController::languagesForUrl(const KUrl &url)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">301</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span><span class="p">(</span><span class="o">!</span><span class="n">extension</span><span class="p">.</span><span class="n">isEmpty</span><span class="p">())</span> <span class="p">{</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">306</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span><span class="p">(</span><span class="n">url</span><span class="p">.</span><span class="n">isLocalFile</span><span class="p">())</span> <span class="p">{</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Nitpick: Space after 'if'</p></pre>
</div>
</div>
<br />
<p>- Kevin Funk</p>
<br />
<p>On July 17th, 2014, 2:42 p.m. UTC, Alexander Richardson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Alexander Richardson.</div>
<p style="color: grey;"><i>Updated July 17, 2014, 2:42 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevplatform
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Port from KMimeType to QMimeType</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>shell/settings/sourceformattersettings.cpp <span style="color: grey">(67b0b6e5cadc6e74d4b1f04e7233fb0499a5309e)</span></li>
<li>shell/sourceformattercontroller.h <span style="color: grey">(2e52884b58aa0b7ad0bc417893270ae02036258f)</span></li>
<li>shell/sourceformattercontroller.cpp <span style="color: grey">(cb44ac55ef432c3f8f68f4b4ac3aa1386ceec0df)</span></li>
<li>shell/textdocument.cpp <span style="color: grey">(3e67236f4e2a6989f83700ddf0a3ba40ddd3a76f)</span></li>
<li>vcs/models/vcsfilechangesmodel.cpp <span style="color: grey">(c3b1afe1a9471d1d9a17d4c69d4d767fccc7eb45)</span></li>
<li>vcs/models/vcsitemeventmodel.cpp <span style="color: grey">(b5de0b1bb6903b565c6b1a0c856176a918247212)</span></li>
<li>debugger/framestack/framestackmodel.cpp <span style="color: grey">(231df7b457c05724e75306abd0a726e495fd7ade)</span></li>
<li>interfaces/context.h <span style="color: grey">(6ffccf2543ebadde08272eed7be0b231561233f7)</span></li>
<li>interfaces/context.cpp <span style="color: grey">(37bc6969a69a58afe7012254dcc199cb13a7011a)</span></li>
<li>interfaces/idocument.h <span style="color: grey">(59fe09937d084f5fe88a1815bb90bd6907781746)</span></li>
<li>interfaces/isourceformatter.h <span style="color: grey">(cc0a50da54b417ac37c8ee1472722e9c3b2cb785)</span></li>
<li>interfaces/isourceformatter.cpp <span style="color: grey">(53946110a7c7555ada6cf6a4f6697a0f799f674c)</span></li>
<li>interfaces/isourceformattercontroller.h <span style="color: grey">(cc8d1ef99dfaf361f8c284892175cfe32f37b0eb)</span></li>
<li>language/codegen/applychangeswidget.cpp <span style="color: grey">(8bd26206a38223158142867127d873986faf2630)</span></li>
<li>language/codegen/documentchangeset.cpp <span style="color: grey">(883e537dedf0977f1195557cf4ed2d87fb156ca7)</span></li>
<li>shell/documentcontroller.cpp <span style="color: grey">(ac5150860cf0ca41d40a0e51b6d3d16a31369441)</span></li>
<li>shell/languagecontroller.cpp <span style="color: grey">(9ec664d152702e0f42cca8a8f1436ad51e3209e3)</span></li>
<li>shell/partcontroller.h <span style="color: grey">(04b29b30b230052b165dda835195a0edcb3ee1b3)</span></li>
<li>shell/partcontroller.cpp <span style="color: grey">(cb42ce7e0c24c6fa3036a00bfeb29ca92edada0a)</span></li>
<li>shell/partdocument.h <span style="color: grey">(2e44c74becc50041491fc9ccf1315d44c9de6529)</span></li>
<li>shell/partdocument.cpp <span style="color: grey">(6330b1e668b6bac7b9353ebd105172322fcb8aeb)</span></li>
<li>shell/settings/editstyledialog.h <span style="color: grey">(50188cae983dbeb2bf00afd3224f4678a005bccc)</span></li>
<li>shell/settings/editstyledialog.cpp <span style="color: grey">(c9fdfb02df15984fe429d5c191fe78fc0aa0492b)</span></li>
<li>shell/settings/sourceformattersettings.h <span style="color: grey">(a46287579fa2d025878b2b1fe002fad35496173e)</span></li>
<li>plugins/appwizard/appwizardplugin.cpp <span style="color: grey">(8e9a001094245c27d54171c57f7e9b62abe05f58)</span></li>
<li>plugins/dashboard/dashboarddocument.h <span style="color: grey">(b63f343aa4162510075378ebb98854f1814a4b8c)</span></li>
<li>plugins/dashboard/dashboarddocument.cpp <span style="color: grey">(e48d83341603283db58512186c1f21f0d7764616)</span></li>
<li>plugins/executescript/scriptappconfig.cpp <span style="color: grey">(e6ec5badbc34e4e9d34a67bb38c087554056df73)</span></li>
<li>plugins/grepview/grepviewplugin.cpp <span style="color: grey">(3709dab63a929f54ee859ca22c5a5487c1eec839)</span></li>
<li>plugins/openwith/openwithplugin.cpp <span style="color: grey">(f9f9e219fde69ead430c58480b90373aed722b3f)</span></li>
<li>plugins/reviewboard/reviewboardjobs.cpp <span style="color: grey">(2fe2ca78366217842cfa1ee226714a23cd99c5f6)</span></li>
<li>plugins/switchtobuddy/switchtobuddyplugin.cpp <span style="color: grey">(6003b304a39d7a37a9b5c5562780803609b524df)</span></li>
<li>project/projectmodel.cpp <span style="color: grey">(74ea6aa604410b46b00b66d0aa65710e5bbc18e8)</span></li>
<li>project/tests/projectmodeltest.cpp <span style="color: grey">(2236a4985d5bd971620c3d26bdfa02e27923c490)</span></li>
<li>language/codegen/templatesmodel.cpp <span style="color: grey">(6d302f026dbfdd47fc93dc531521585af53e1bb7)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119338/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>