Review Request 109422: Fix mingw64 compiler errors

[Aleix Pol Gonzalez]

> On March 11, 2013, 4:10 p.m., Florian Eßer wrote:
> > tests/json/jsontesthelpers.h, line 53
> > <http://git.reviewboard.kde.org/r/109422/diff/2/?file=119255#file119255line53>
> >
> >     stumbled upon this while building kdevelop ("emerge kdevelop"):
> >     
> >     jsontesthelpers.h:53: error: expected unqualified-id before numeric constant
> >     
> >     Somehow, mingw64 seems to have a problem with a variable named ERROR. Renaming it solved the problem for me.

Renaming this is fine, although I think it would be nicer to have the string used automatically, I don't like .arg() against a variable.

Of course, that's not your problem, so a simple rename is ok.


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109422/#review29000
-----------------------------------------------------------


On March 11, 2013, 4:08 p.m., Florian Eßer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109422/
> -----------------------------------------------------------
> 
> (Updated March 11, 2013, 4:08 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> I tried to "emerge kdevplatform" under Windows7 / mingw64, but ran into some errors.
> 
> These are the fixes I used to make it compile again.
> 
> 
> Diffs
> -----
> 
>   language/codecompletion/normaldeclarationcompletionitem.cpp d0456b2 
>   tests/json/CMakeLists.txt 68550b6 
>   tests/json/declarationvalidator.h 2a1d971 
>   tests/json/delayedoutput.h 8b3fea1 
>   tests/json/jsontesthelpers.h 8f62f4a 
>   tests/json/kdevplatformjsontestsexport.h e69de29 
>   tests/json/testsuite.h 51f5051 
> 
> Diff: http://git.reviewboard.kde.org/r/109422/diff/
> 
> 
> Testing
> -------
> 
> "emerge kdevplatform" now finishes without error.
> 
> 
> Thanks,
> 
> Florian Eßer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130311/7a5b9374/attachment.html>