<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109422/">http://git.reviewboard.kde.org/r/109422/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 11th, 2013, 4:10 p.m. UTC, <b>Florian Eßer</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/109422/diff/2/?file=119255#file119255line53" style="color: black; font-weight: bold; text-decoration: underline;">tests/json/jsontesthelpers.h</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">const QString SUCCESS = QString();</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">53</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">const</span> <span class="n">QString</span> <span class="n">ERROR</span> <span class="o">=</span> <span class="s">"%1 (</span><span class="se">\"</span><span class="s">%2</span><span class="se">\"</span><span class="s">) doesn't match test data (</span><span class="se">\"</span><span class="s">%3</span><span class="se">\"</span><span class="s">)."</span><span class="p">;</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">53</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">const</span> <span class="n">QString</span> <span class="n">ERROR<span class="hl">_MESSAGE</span></span> <span class="o">=</span> <span class="s">"%1 (</span><span class="se">\"</span><span class="s">%2</span><span class="se">\"</span><span class="s">) doesn't match test data (</span><span class="se">\"</span><span class="s">%3</span><span class="se">\"</span><span class="s">)."</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">stumbled upon this while building kdevelop ("emerge kdevelop"):
jsontesthelpers.h:53: error: expected unqualified-id before numeric constant
Somehow, mingw64 seems to have a problem with a variable named ERROR. Renaming it solved the problem for me.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Renaming this is fine, although I think it would be nicer to have the string used automatically, I don't like .arg() against a variable.
Of course, that's not your problem, so a simple rename is ok.</pre>
<br />
<p>- Aleix</p>
<br />
<p>On March 11th, 2013, 4:08 p.m. UTC, Florian Eßer wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Florian Eßer.</div>
<p style="color: grey;"><i>Updated March 11, 2013, 4:08 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I tried to "emerge kdevplatform" under Windows7 / mingw64, but ran into some errors.
These are the fixes I used to make it compile again.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">"emerge kdevplatform" now finishes without error.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>language/codecompletion/normaldeclarationcompletionitem.cpp <span style="color: grey">(d0456b2)</span></li>
<li>tests/json/CMakeLists.txt <span style="color: grey">(68550b6)</span></li>
<li>tests/json/declarationvalidator.h <span style="color: grey">(2a1d971)</span></li>
<li>tests/json/delayedoutput.h <span style="color: grey">(8b3fea1)</span></li>
<li>tests/json/jsontesthelpers.h <span style="color: grey">(8f62f4a)</span></li>
<li>tests/json/kdevplatformjsontestsexport.h <span style="color: grey">(e69de29)</span></li>
<li>tests/json/testsuite.h <span style="color: grey">(51f5051)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109422/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>