Review Request: Add nested view in the class browser plugin.

[Ghislain Mary]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104932/
-----------------------------------------------------------

(Updated May 24, 2012, 2:08 p.m.)


Review request for KDevelop.


Changes
-------

This new patch is quite different compared to the last one. Here are the changes:
 - Fixed the issues reported by Milian.
 - Fixed the filtering in nested view (it was not working at all with the previous patch)
 - Replaced the search line edit by a filter action (as it is done in the projectmanagerview plugin)
 - Changed some icons (those of the project, "Base classes" and "Derived classes" directories). Any better icon ideas are welcome!
See the attached screenshot to see what it looks like.


Summary (updated)
-----------------

Add nested view in the class browser plugin.


Description
-------

It enables the user to navigate the project tree and list the classes defined in each directory of the project.

Some more work would be needed after this to improve the search function. I think we should replace the search lineedit by a "Filter..." action as in the projectmanagerview plugin so it is more consistent. And then when the user enters a filter we should use automatically the flat view because otherwise the user will probably not see the result of his filtering.


This addresses bug 212583.
    http://bugs.kde.org/show_bug.cgi?id=212583


Diffs (updated)
-----

  plugins/classbrowser/classmodel.h fd1eed5 
  plugins/classbrowser/classmodel.cpp f9956c6 
  plugins/classbrowser/classmodelnode.h 739868b 
  plugins/classbrowser/classmodelnode.cpp 334f424 
  plugins/classbrowser/classwidget.h 1e1ed58 
  plugins/classbrowser/classwidget.cpp f5a9517 
  plugins/classbrowser/projectfolder.h d951a86 
  plugins/classbrowser/projectfolder.cpp 419cb79 

Diff: http://git.reviewboard.kde.org/r/104932/diff/


Testing
-------

I used it on the kdevplatform and kdevelop sources and have seen no problem.


Screenshots (updated)
-----------

Nested view in class browser plugin
  http://git.reviewboard.kde.org/r/104932/s/576/


Thanks,

Ghislain Mary

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120524/a374365c/attachment.html>